From b65227445c2fb36c04c034ed27a82790b27e3d9f Mon Sep 17 00:00:00 2001 From: Christopher Warner Date: Sat, 10 Oct 2026 18:49:42 -0400 Subject: chore(security): document and guard against committing iCloud sessions Confirm the public tree has no Apple credentials, harden .gitignore, add SECURITY.md, and fail CI-style tests if session/secret files are tracked. Co-authored-by: Cursor --- tests/run.sh | 3 +++ tests/secrets-guard.test.sh | 39 +++++++++++++++++++++++++++++++++++++++ 2 files changed, 42 insertions(+) create mode 100755 tests/secrets-guard.test.sh (limited to 'tests') diff --git a/tests/run.sh b/tests/run.sh index f34fd3e..a1f6fd3 100755 --- a/tests/run.sh +++ b/tests/run.sh @@ -12,4 +12,7 @@ echo "== cli ==" echo "== conventional commits ==" ./tests/conventional-commits.test.sh +echo "== secrets guard ==" +./tests/secrets-guard.test.sh + echo "All tests passed." diff --git a/tests/secrets-guard.test.sh b/tests/secrets-guard.test.sh new file mode 100755 index 0000000..338206a --- /dev/null +++ b/tests/secrets-guard.test.sh @@ -0,0 +1,39 @@ +#!/usr/bin/env bash +# Fail if tracked files look like Apple/iCloud session material or secrets. +set -euo pipefail + +ROOT="$(cd "$(dirname "$0")/.." && pwd)" +cd "$ROOT" + +fail() { echo "FAIL: $*" >&2; exit 1; } +pass() { echo "ok: $*"; } + +# Filenames that must never be tracked +BAD_NAME_RE='(storage-state\.json|session\.ok|cookies\.json|(^|/)Cookies$|\.env$|\.pem$|\.key$|credentials\.json|secrets\.ya?ml|browser-profile/)' + +mapfile -t TRACKED < <(git ls-files) +[[ "${#TRACKED[@]}" -gt 0 ]] || fail "no tracked files" + +for f in "${TRACKED[@]}"; do + if [[ "$f" =~ $BAD_NAME_RE ]]; then + fail "tracked forbidden path: $f" + fi +done +pass "no forbidden secret filenames tracked" + +# Content heuristics on tracked text (skip lockfile binary-ish noise) +CONTENT_RE='X-APPLE-WEBAUTH|X-APPLE-DS-WEB-SESSION|myacinfo|BEGIN (RSA |OPENSSH )?PRIVATE KEY|appleidpassword|ICLOUD_PASSWORD\s*=' +hits="$(git grep -nI -E "$CONTENT_RE" -- . ':(exclude)Cargo.lock' ':(exclude)SECURITY.md' ':(exclude)tests/secrets-guard.test.sh' || true)" +if [[ -n "$hits" ]]; then + echo "$hits" >&2 + fail "tracked content matches secret heuristics" +fi +pass "no secret-like content in tracked files" + +# Ensure session dir is outside the repo by default +if [[ -e "$ROOT/browser-profile" || -e "$ROOT/storage-state.json" || -e "$ROOT/session.ok" ]]; then + fail "session material present in repo working tree (use ~/.config/icloud-notes/)" +fi +pass "no session material in repo working tree" + +echo "All secrets-guard checks passed." -- cgit v1.2.3